Conversation
dunglas
force-pushed
the
docs/contributing-windows
branch
from
3fdfd73 to
11629d2
Compare
henderkes
requested changes
Feb 26, 2026
Contributor
henderkes
left a comment
henderkes
left a comment
There was a problem hiding this comment.
It would be nice if Microsoft could merge in watcher-c support into vcpkg.
I also think we should add configuration on how to build and run the app in an IDE (e.g. GoLand). It's luckily a bit simpler on Windows than with WSL, but still not completely hands-off.
Correct grammar and punctuation throughout the document. Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
Updated formatting and instructions for Docker and Windows development. Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
Added instructions for installing Visual Studio, Git, Go, and vcpkg. Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
Updated section titles for consistency and capitalization. Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
dunglas
force-pushed
the
docs/contributing-windows
branch
from
8fb1787 to
3f3c689
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Windows-specific contributor guidance and adjusts CI to run tests with the race detector on Windows.
Changes:
- Add a “Windows Development” section to
CONTRIBUTING.mdwith setup, environment, test, and build steps. - Normalize some headings/wording in
CONTRIBUTING.md(title case, punctuation/grammar tweaks). - Update the Windows GitHub Actions workflow test commands to attempt running with
-race.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
CONTRIBUTING.md |
Adds Windows development instructions and polishes existing contributing docs. |
.github/workflows/windows.yaml |
Modifies Windows CI test invocation to include the race detector. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
Updated CGO_CFLAGS and CGO_LDFLAGS for improved paths. Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
henderkes
reviewed
Mar 3, 2026
Updated CGO_CFLAGS to include optimization flags. Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.