Conversation
iggyvolz
commented
Dec 24, 2021
| "ext-sqlite3": "*", | ||
| "ext-xmlreader": "*" | ||
| "ext-xmlreader": "*", | ||
| "ext-simplexml": "*" |
Author
There was a problem hiding this comment.
SimpleXML is used in phpdotnet\phd\Package\IDE\API so I added that here
iggyvolz
commented
Dec 24, 2021
| namespace phpdotnet\phd\Options; | ||
|
|
||
| interface Options_Interface { | ||
| interface OptionsInterface { |
Author
There was a problem hiding this comment.
Name here should be "Interface" which is not a valid class name
iggyvolz
commented
Dec 24, 2021
| @@ -1,7 +1,12 @@ | |||
| <?php | |||
| namespace phpdotnet\phd; | |||
| namespace phpdotnet\phd\Format\_Abstract; | |||
Author
There was a problem hiding this comment.
Abstract cannot be a namespace part - using _Abstract here
iggyvolz
commented
Dec 24, 2021
| * @link https://doc.php.net/phd/ | ||
| */ | ||
| class Package_IDE_API_Function | ||
| class _Function |
Author
There was a problem hiding this comment.
Function is not a valid PHP class name
Member
|
See #52 |
Author
Whoops not sure how I missed that, sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.php-fig.org/psr/psr-0/:
Used the PHPStorm refactoring tools as well as some manual labor to move all the classes to their correct location and use namespaces rather than underscores. Also uses Composer's autoloader rather than the ad-hoc one.
Definitely needs some more testing to make sure it covers every possible class name access - there are some places where classes were accessed by strings but I think I got all of those.
PDF renderer removed in the process, as per #60 (comment).
Feel free to close if this is too ambitious or too much change all at once.