Fixes #20967 Support range of INT64_MIN/MAX on 32bit for DateTime[Immutable]::createFromTimestamp #18857
+63
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@derickr ping |
derickr
requested changes
Jan 13, 2026
Member
derickr
left a comment
derickr
left a comment
There was a problem hiding this comment.
This should get an entry in the NEWS file too, or ideally with a reference to a GH- bug report.
marc-mabe
changed the title
…sses support for 64bit integers or 32bit environments
marc-mabe
force-pushed
the
createFromTimestamp-float-int64
branch
from
d9e3738 to
e77c9f8
Compare
Contributor
Author
|
@derickr Created and referenced a GH bug ticket + NEWs entry and - as referenced as bug - targeting PHP 8.4 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timelib internally uses
timelib_sllto store the unix timestamp which isint64_t.This PR allows a range of
INT64_MIN to INT64_MAX.999999on 32 bit environments as well if initialized bycreateFromTimestamp(float).This fixes #20967