-
Notifications
You must be signed in to change notification settings - Fork 8k
Mysqli: fix missing error for invalid mysqli_options() option #20971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arshidkv12
wants to merge
10
commits into
php:master
Choose a base branch
from
arshidkv12:mysql-option
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−2
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a401699
Fix bug gh20968
arshidkv12 217b19b
mysqli: raise ValueError for invalid option in mysqli_options() respe…
arshidkv12 66fbc0a
mysqli: raise ValueError for invalid option in mysqli_options() respe…
arshidkv12 54a8e06
mysqli: raise ValueError for invalid option in mysqli_options() respe…
arshidkv12 0716f97
mysqli: raise ValueError for invalid option in mysqli_options() respe…
arshidkv12 d7dd938
mysqli: raise ValueError for invalid option in mysqli_options() respe…
arshidkv12 1aa360a
mysqli: raise ValueError for invalid option in mysqli_options() respe…
arshidkv12 04f8006
Update ext/mysqli/mysqli_api.c
arshidkv12 9ba4bf2
Update ext/mysqli/tests/gh20968.phpt
arshidkv12 2db6e98
mysqli: raise ValueError for invalid option in mysqli_options() respe…
arshidkv12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| --TEST-- | ||
| Bug #20968 mysqli_options() with invalid option triggers ValueError | ||
| --EXTENSIONS-- | ||
| mysqli | ||
| --CONFLICTS-- | ||
| mysqli | ||
| --SKIPIF-- | ||
| <?php | ||
| require_once 'skipifconnectfailure.inc'; | ||
| ?> | ||
| --FILE-- | ||
| <?php | ||
| require_once 'connect.inc'; | ||
|
|
||
| $driver = new mysqli_driver(); | ||
|
|
||
| $mysqli = new mysqli($host, $user, $passwd, $db, $port, $socket); | ||
|
|
||
| $driver->report_mode = MYSQLI_REPORT_OFF; | ||
| $value = $mysqli->options(10, 'invalid_option'); | ||
|
|
||
| var_dump($value); | ||
|
|
||
| $driver->report_mode = MYSQLI_REPORT_ALL; | ||
| $value = $mysqli->options(10, 'invalid_option'); | ||
| var_dump($value); | ||
|
|
||
| ?> | ||
| --EXPECTF-- | ||
| bool(false) | ||
|
|
||
| Fatal error: Uncaught ValueError: mysqli_options(): Invalid option %d in %s:%d | ||
| Stack trace: | ||
| #0 %s(%d): mysqli->options(%d, 'invalid_option') | ||
| #1 {main} | ||
| thrown in %s on line %d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.