Skip to content

Hide (packed) hint for ZEND_INIT_ARRAY with op1=UNUSED #20982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
iluuu1994 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −6
Draft

Hide (packed) hint for ZEND_INIT_ARRAY with op1=UNUSED #20982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Zend/Optimizer/zend_dump.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ ZEND_API void zend_dump_op(const zend_op_array *op_array, const zend_basic_block
}
if (ZEND_VM_EXT_ARRAY_INIT & flags) {
fprintf(stderr, " %u", opline->extended_value >> ZEND_ARRAY_SIZE_SHIFT);
Copy link
Member

@TimWolla TimWolla Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially even this should be suppressed, since no initialization is happening? No strong opinion either way, not my primary area of the code.

if (!(opline->extended_value & ZEND_ARRAY_NOT_PACKED)) {
if (opline->op1_type != IS_UNUSED && !(opline->extended_value & ZEND_ARRAY_NOT_PACKED)) {
fprintf(stderr, " (packed)");
}
}
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/array/array_map_foreach_optimization_001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ $_main:
0003 V2 = DO_ICALL
0004 ASSIGN CV0($array) V2
0005 TYPE_ASSERT 131079 string("array_map") CV0($array)
0006 T2 = INIT_ARRAY 0 (packed) NEXT
0006 T2 = INIT_ARRAY 0 NEXT
0007 V3 = FE_RESET_R CV0($array) 0014
0008 T5 = FE_FETCH_R V3 T4 0014
0009 INIT_FCALL 1 %d string("plus1")
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/array/array_map_foreach_optimization_002.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ $_main:
0006 SEND_VAR%S CV0($array) 1
0007 DO_FCALL
0008 TYPE_ASSERT 131079 string("array_map") V5
0009 T2 = INIT_ARRAY 0 (packed) NEXT
0009 T2 = INIT_ARRAY 0 NEXT
0010 V3 = FE_RESET_R V5 0017
0011 T5 = FE_FETCH_R V3 T4 0017
0012 INIT_FCALL 1 %d string("plus1")
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/array/array_map_foreach_optimization_003.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ $_main:
; (after optimizer)
; %s
0000 TYPE_ASSERT 131079 string("array_map") array(...)
0001 T1 = INIT_ARRAY 0 (packed) NEXT
0001 T1 = INIT_ARRAY 0 NEXT
0002 V2 = FE_RESET_R array(...) 0009
0003 T4 = FE_FETCH_R V2 T3 0009
0004 INIT_FCALL 1 %d string("plus1")
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/array/array_map_foreach_optimization_004.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ $_main:
0003 V1 = DO_ICALL
0004 ASSIGN CV0($array) V1
0005 TYPE_ASSERT 131079 string("array_map") CV0($array)
0006 T1 = INIT_ARRAY 0 (packed) NEXT
0006 T1 = INIT_ARRAY 0 NEXT
0007 V2 = FE_RESET_R CV0($array) 0014
0008 T4 = FE_FETCH_R V2 T3 0014
0009 INIT_FCALL 1 %d string("stdclass")
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/array/array_map_foreach_optimization_005.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ $_main:
0003 V2 = DO_ICALL
0004 ASSIGN CV0($array) V2
0005 TYPE_ASSERT 131079 string("array_map") CV0($array)
0006 T2 = INIT_ARRAY 0 (packed) NEXT
0006 T2 = INIT_ARRAY 0 NEXT
0007 V3 = FE_RESET_R CV0($array) 0014
0008 T5 = FE_FETCH_R V3 T4 0014
0009 INIT_STATIC_METHOD_CALL 1 string("Adder") string("plus1")
Expand Down
Loading