Skip to content

Make AssertSameBooleanExpectedRule auto-fixable #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.0.x
Choose a base branch
from
Open

Make AssertSameBooleanExpectedRule auto-fixable #252

wants to merge 1 commit into from

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Oct 30, 2025 •
edited
Loading

refs #249

staabm
staabm commented Oct 30, 2025
View reviewed changes
src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php
),
)->identifier('phpunit.assertEquals')
->fixNode($node, static function (CallLike $node) use ($correctName) {
if ($node instanceof Node\Expr\MethodCall) {
Copy link
Contributor Author

@staabm staabm Oct 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since a recent change we have

if (!$node instanceof Node\Expr\MethodCall && ! $node instanceof Node\Expr\StaticCall) {
			return [];
}

at the very top of this rule, therefore we don't need to narrow here again anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@staabm