Feature/jgqo373 watermark decorator by NadiaAbraham · Pull Request #23 · phuse-org/uteals

NadiaAbraham · 2026-02-06T14:12:23Z

New watermark decorator for plots. Currently we are not supporting rtables

…com/phuse-org/uteals into feature/jgqo373_watermark_decorator

kpagacz · 2026-03-03T08:03:53Z

R/watermark_decorator.R

+              output_name <- gridify::gridify(
+                object = cowplot::as_grob(output_name),
+                layout = gridify_layout
+              ) %>%


Let's not use %>% in the decorators if we don't have to do it. There's |> which is a sufficient replacement here

R/watermark_decorator.R

kpagacz · 2026-03-03T08:05:04Z

R/watermark_decorator.R

+                object = cowplot::as_grob(output_name),
+                layout = gridify_layout
+              ) %>%
+                set_cell("watermark", watermark_text)


set_cell is from rtables?

set_cell is from gridify...added package reference

kpagacz · 2026-03-03T08:05:36Z

R/watermark_decorator.R

+          res <- within(
+            res,
+            {
+              watermark_text <- txtWatermark


I fail to see the point of this line

Removed redundant code

kpagacz · 2026-03-03T08:06:19Z

R/watermark_decorator.R

+#' @param watermark_text (`character(1)`) text to display for the watermark
+#' @param font_size (`character(1)`) font size for the watermark text


Suggested change

#' @param watermark_text (`character(1)`) text to display for the watermark

#' @param font_size (`character(1)`) font size for the watermark text

#' @param watermark_text (`character(1)`) text to display for the watermark.

#' @param font_size (`character(1)`) font size for the watermark text.

kpagacz · 2026-03-03T08:06:38Z

R/watermark_decorator.R

+#' @details The module creates a UI with textInput for specifying watermark text and
+#' font size.


Suggested change

#' @details The module creates a UI with textInput for specifying watermark text and

#' font size.

#' @details The module creates a UI with `textInput` for specifying watermark text and

#' font size.

kpagacz · 2026-03-03T08:06:47Z

R/watermark_decorator.R

+#'
+#' @details The module creates a UI with textInput for specifying watermark text and
+#' font size.
+#' the entered watermark text is displayed with a default gridify layout.


Suggested change

#' the entered watermark text is displayed with a default gridify layout.

#' the entered watermark text is displayed with a default `gridify` layout.

In case you are wondering why it matters - part of the CI is spell checking the package. Anything inside `` is not spell checked, anything outside is. gridify is not a real word, so it will be flagged by our spell check

Sure Konrad...made the update

kpagacz · 2026-03-03T08:08:15Z

R/watermark_decorator.R

+#' font size.
+#' the entered watermark text is displayed with a default gridify layout.
+#'
+#' @import cowplot gridify rtables.officer


Why is rtables.officer needed?

This was needed for the tables. Will remove as we are not enabling this decorator for tables now. Thanks for pointing it out

github-actions · 2026-03-03T13:23:23Z

Code Coverage Summary

Filename                                     Stmts    Miss  Cover    Missing
-----------------------------------------  -------  ------  -------  ---------
R/BlockConditions.R                             14      14  0.00%    23-54
R/create_rel_risk_transformator.R               43      43  0.00%    36-84
R/forest_plot_decorator.R                      164     164  0.00%    97-373
R/ggplot_decorator.R                           244     244  0.00%    84-355
R/merge_levels_transformator.R                 146     146  0.00%    11-240
R/or_filtering_transformator_view_model.R       27      27  0.00%    26-64
R/or_filtering_transformator.R                 254     254  0.00%    69-369
R/patchwork_plot_decorator.R                    46      46  0.00%    18-68
R/r_access_utilities.R                          46      46  0.00%    32-152
R/title_footer_decorator.R                     130     130  0.00%    103-241
R/watermark_decorator.R                         61      61  0.00%    23-87
TOTAL                                         1175    1175  0.00%

Diff against main

Filename                          Stmts    Miss  Cover
------------------------------  -------  ------  --------
R/merge_levels_transformator.R       +6      +6  +100.00%
R/watermark_decorator.R             +61     +61  +100.00%
TOTAL                               +67     +67  +100.00%

Results for commit: 4f0813e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

…e-org/uteals into feature/jgqo373_watermark_decorator

Nadia Abraham added 3 commits January 7, 2026 05:44

Watermark decorator changes

62fd702

minor fixes and added documentation

3f8f6c7

Removed code for table is its not currently supported as required

7727822

NadiaAbraham requested a review from kpagacz February 6, 2026 14:12

Nadia Abraham and others added 5 commits February 6, 2026 09:13

Doc changes

6e3e5b0

Conflicts resolved

78c0f78

[skip style] [skip vbump] Restyle files

dac4079

NEWS entry added

b52934f

Merge branch 'feature/jgqo373_watermark_decorator' of https://github.…

cfc3efb

…com/phuse-org/uteals into feature/jgqo373_watermark_decorator

kpagacz requested changes Mar 3, 2026

View reviewed changes

Nadia Abraham and others added 3 commits March 3, 2026 05:28

Changes as per review feedback

18ef146

Merge branch 'main' into feature/jgqo373_watermark_decorator

9ee94eb

[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update

7101c03

kpagacz self-requested a review March 3, 2026 13:27

kpagacz and others added 5 commits March 3, 2026 14:34

Merge branch 'main' into feature/jgqo373_watermark_decorator

494dabb

[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update

66f4338

fix all the issues

63cdcd6

Merge branch 'feature/jgqo373_watermark_decorator' of github.com:phus…

dbefe47

…e-org/uteals into feature/jgqo373_watermark_decorator

run styler

4f0813e

kpagacz approved these changes Mar 3, 2026

View reviewed changes

kpagacz merged commit ea765aa into main Mar 3, 2026
25 checks passed

kpagacz deleted the feature/jgqo373_watermark_decorator branch March 3, 2026 20:19

		#' @param watermark_text (`character(1)`) text to display for the watermark
		#' @param font_size (`character(1)`) font size for the watermark text

		#' @details The module creates a UI with textInput for specifying watermark text and
		#' font size.

	#' the entered watermark text is displayed with a default gridify layout.
	#' the entered watermark text is displayed with a default `gridify` layout.

Conversation

NadiaAbraham commented Feb 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Diff against main

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Mar 3, 2026 •

edited

Loading