Standalone: Improve detecting Nginx startup error messages #2611
Conversation
Upgrades daemon_controller to 3.0.0.
[ci skip]
CamJN
left a comment
CamJN
left a comment
There was a problem hiding this comment.
In a few cases I commented on a code style thing in one place but I mean the style applies generally.
src/ruby_supportlib/phusion_passenger/vendor/daemon_controller.rb
Outdated
Show resolved
Hide resolved
src/ruby_supportlib/phusion_passenger/vendor/daemon_controller.rb
Outdated
Show resolved
Hide resolved
src/ruby_supportlib/phusion_passenger/vendor/daemon_controller.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CamJN
left a comment
CamJN
left a comment
There was a problem hiding this comment.
Just one last comment, maybe we should have passenger set its exiting defaults at the call sites for daemon controller, so that we don't mess things up for our customers again?
| # See doc/OPTIONS.md for options docs. | ||
| def initialize(identifier:, start_command:, ping_command:, pid_file:, log_file:, | ||
| lock_file: nil, stop_command: nil, restart_command: nil, before_start: nil, | ||
| start_timeout: 30, start_abort_timeout: 10, stop_timeout: 30, |
There was a problem hiding this comment.
We're changing the defaults here, and @tinco said that caused issues for at least one customer the last time we did it.
There was a problem hiding this comment.
Good that you flag this. The changing of defaults is necessary to solve some issues, including issues that we've run into. I think it should be acceptable if we communicate this properly. Maybe bump the minor version again? That is, we go to 6.2.0.
There was a problem hiding this comment.
Sure can you bump the version and update the changelog with the changed defaults then?
Upgrades daemon_controller to 3.0.2.
Closes #1970.