Fix noisy shutdown warnings from worker pool and bridge#173
Open
sueszli wants to merge 2 commits intopiercefreeman:mainfrom
Open
Fix noisy shutdown warnings from worker pool and bridge#173sueszli wants to merge 2 commits intopiercefreeman:mainfrom
sueszli wants to merge 2 commits intopiercefreeman:mainfrom
Conversation
Contributor
Author
|
Reproduce with: https://gist.github.com/sueszli/70d1fc670e9e805eb1f6d42cc923d70d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs caused spurious warnings on every clean shutdown:
RemoteWorkerPool::launch()clonedArc<PythonWorkerPool>into the dispatcher task, keeping the refcount above 1. Whenshutdown()calledArc::try_unwrap(inner.pool)it always failed, skipping pool shutdown entirely (and with it, bridge shutdown). Fixed by holding Weak in the dispatcher and upgrading per-request instead.WorkerBridgeServerreader tasks warn on stream errors, but killing worker processes necessarily closes their gRPC connections with a broken pipe. Fixed by adding ashutting_downflag toWorkerBridgeState, set viamark_shutting_down()before the worker-kill loop, so expected connection errors during planned shutdown are silenced. Unexpected errors during normal operation still warn.Additionally mutes build warning: