Switch shutdown logic to cancellation tokens [4 / 4]#185
Closed
MOZGIII wants to merge 4 commits intopiercefreeman:mainfrom
Closed
Switch shutdown logic to cancellation tokens [4 / 4]#185MOZGIII wants to merge 4 commits intopiercefreeman:mainfrom
MOZGIII wants to merge 4 commits intopiercefreeman:mainfrom
Conversation
MOZGIII
changed the title
MOZGIII
force-pushed
the
refactors-2
branch
2 times, most recently
from
884cab3 to
b92b9dd
Compare
MOZGIII
changed the title
Collaborator
Author
|
See #197 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review: b92b9dd
This goes in after #184
This PR unifies the inconsistent use of various primitives for graceful shutdown logic to using
tokio_util::sync::CancellationTokeneverywhere.It also provides more explicit control over whether the runloop should exit when idle or now.
While working on this, I've had two instances of the tests catching behavior changes - so I appreciate the test coverage.