Mass refactor the crates structure [7 / 4]#191
Closed
MOZGIII wants to merge 12 commits intopiercefreeman:mainfrom
Closed
Mass refactor the crates structure [7 / 4]#191MOZGIII wants to merge 12 commits intopiercefreeman:mainfrom
MOZGIII wants to merge 12 commits intopiercefreeman:mainfrom
Conversation
79fa0fc to
c052675
Compare
Collaborator
Author
|
See #200 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a huge PR that I've built as a PoC for the more atomic crates; we can merge it as-is, or I can subdivide it into smaller parts so we can review individual changes.
Commits to review start with
Split out ir parser into a separate crate: review.The totality of the changes in this PR are:
usestatementsThere are no semantic changes to the code, or tests; in fact, most of the files remain as-is, and don't really have any associated changes at all but the
usesection update and new placement.This is the majority of the work required to split out the monolithic crate structure into small and atomic crates; we have resolved all of the dependency cycle issues and establish necessary patterns to move forward.
waymark-<subsystem>-backendcrates andwaymark-<subsystem>-corecrates.waymark-runnerandwaymark-runner-state; that last one could've been calledwaymark-runner-core, and that it because it holds the core types used bywaymark-core-backendAgain, this refactor only moves code around. It does apply no changes to the type names, or fn implementations (except correcting the item paths when they're affected by code movements).