Generate the identity when running generate(a,a)#28
Open
blottn wants to merge 4 commits intopierreinglebert:masterfrom
Open
Generate the identity when running generate(a,a)#28blottn wants to merge 4 commits intopierreinglebert:masterfrom
generate(a,a)#28blottn wants to merge 4 commits intopierreinglebert:masterfrom
Conversation
Also includes refactor to simplify code and updates tests to match new functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the RFC,
apply(a, {})is a noop. However when runninggenerate(a,a)the output isundefined. This is undesirable since then the result of doingapply(a, generate(a,a))is nota.This patch updates the function generate to instead return
{}in cases where nothing should be changed.This also changes the result of some tests. I have updated the tests to expect the new result but I that this likely results in breaking changes for users.