[Bugfix] Display search button in pimcore.helpers.editmode.openLinkEditPanel only when search is available#1056
Merged
kingjia90 merged 1 commit intopimcore:1.7from Jan 19, 2026
Conversation
… only when search is available
|
Contributor
Author
|
Now that we finally upgraded to Pimcore 11 and I can use this feature, I noticed that we forgot to support subtypes and classes in pimcore/pimcore#13173 😞 In the hope that it counts as a bugfix (and we don't have to wait again till we upgrade to Pimcore 12), here are the PRs that add it: |
Contributor
|
Thank you for the follow up PR! Ops, messed up (mixed up with #1057 🙅🏻 ), the base branch is still 1.7 on this, but won't be tagged until next LTS then.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The button has been defined twice: once conditionally and once inline.
The inline definition is removed in favor of the conditional one.
Otherwise, the button is show even is no search implementation is available but does nothing on click.
This was an oversight in pimcore/pimcore#13173.