[Bug]: Prevent self-deletion of admin users in UserController#1086
Merged
[Bug]: Prevent self-deletion of admin users in UserController#1086
Conversation
Added a guard clause to prevent self-deletion of admin users.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the admin user deletion endpoint by preventing administrators from deleting their own accounts when calling the API directly, aligning backend behavior with the frontend.
Changes:
- Added a self-deletion guard to
UserController::deleteAction()alongside existing admin/folder deletion checks. - Updated inline comments to document the new guard behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a guard clause to prevent self-deletion of admin users.
Only relevant if the request was sent directly to the API, not through the UI (it's disabled in there)
Not a strict security issue, just a design/logic flaw
Resolves https://github.com/pimcore/pimcore/security/advisories/GHSA-x4vx-7h2p-c6f7