Speed up grpc fetch and query response parsing #537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Running a profiler on my pinecone-using application. it was CPU-bottlenecked on
json_format.MessageToDict(being able to do about 100 vectors per second in query and fetch responses).It turns out converting the embeddings to a dict this way is very slow. It's much faster to convert them to a list without going through
MessageToDict.Solution
Changed
parse_fetch_responseandparse_query_responseto directly read the protobuf structure instead of going throughMessageToDictType of Change
Test Plan
Describe specific steps for validating this change.
make test-grpc-unit.