Skip to content

Conversation

@ti-chi-bot
Copy link
Member

Check List

Tests

  • No need to test
    • I checked and no code files have been changed.

[skip ci] Update OWNERS file

skip-checks: true
Signed-off-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
[skip ci] Update OWNERS file

skip-checks: true
Signed-off-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly streamlines the management of code ownership by transitioning the OWNERS file from a static list of individuals to a dynamic, alias-based system. By introducing sig-community-approvers and sig-community-reviewers aliases, which are defined in OWNERS_ALIASES and synced from a central community repository, the change aims to automate and simplify the maintenance of ownership definitions, ensuring consistency and reducing manual updates.

Highlights

  • OWNERS File Refactoring: The OWNERS file has been refactored to replace explicit lists of individual approvers and reviewers with references to role-based aliases: sig-community-approvers and sig-community-reviewers.
  • New Aliases Introduced: Two new aliases, sig-community-approvers and sig-community-reviewers, have been added to the OWNERS_ALIASES file, containing the individual members previously listed directly in the OWNERS file.
  • Automated Membership Sync: The OWNERS and OWNERS_ALIASES files now include comments indicating that community memberships are synced automatically from the pingcap/community repository, centralizing and streamlining the management of these roles.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2025
@ti-chi-bot
Copy link
Member Author

/release-note-none

@ti-chi-bot ti-chi-bot added approved lgtm skip-issue-check Indicates that a PR no need to check linked issue. translation/no-need No need to translate this PR. labels Oct 27, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Oct 27, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the OWNERS and OWNERS_ALIASES files to use aliases for approvers and reviewers, which will be synced from the pingcap/community repository. This is a great improvement for maintainability. The changes look good. I've added a couple of minor suggestions to sort the new alias lists alphabetically to further improve readability.

Comment on lines +18 to +38
sig-community-reviewers:
- 3pointer
- GMHDBJD
- Joyinqin
- KanShiori
- Yisaer
- amyangfei
- anotherrachel
- aylei
- crazycs520
- dveeden
- ericsyh
- glkappe
- junlan-zhang
- lucklove
- lysu
- ngaut
- superlzs0476
- tiancaiamao
- weekface
- zimulala

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

For better readability and easier maintenance, it's a good practice to keep lists of usernames sorted alphabetically. The previous OWNERS file had sorted lists, so it would be good to maintain that convention.

  sig-community-reviewers:
    - 3pointer
    - amyangfei
    - anotherrachel
    - aylei
    - crazycs520
    - dveeden
    - ericsyh
    - glkappe
    - GMHDBJD
    - Joyinqin
    - junlan-zhang
    - KanShiori
    - lucklove
    - lysu
    - ngaut
    - superlzs0476
    - tiancaiamao
    - weekface
    - Yisaer
    - zimulala

Comment on lines +39 to +51
sig-community-approvers:
- Icemap
- Oreoxmt
- breezewish
- csuzhangxc
- hfxsd
- jackysp
- kissmydb
- lance6716
- lilin90
- overvenus
- qiancai
- tangenta

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

For better readability and easier maintenance, it's a good practice to keep lists of usernames sorted alphabetically. The previous OWNERS file had sorted lists, so it would be good to maintain that convention.

  sig-community-approvers:
    - breezewish
    - csuzhangxc
    - hfxsd
    - Icemap
    - jackysp
    - kissmydb
    - lance6716
    - lilin90
    - Oreoxmt
    - overvenus
    - qiancai
    - tangenta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants