- 
                Notifications
    You must be signed in to change notification settings 
- Fork 706
OWNERS: Auto Sync OWNERS files from community membership #21972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| [APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. 
Needs approval from an approver in each of these files:
 Approvers can indicate their approval by writing  | 
| Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly streamlines the management of code ownership by transitioning the  Highlights
 Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either  
 Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a  Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
 | 
| /release-note-none | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the OWNERS and OWNERS_ALIASES files to use aliases for approvers and reviewers, which will be synced from the pingcap/community repository. This is a great improvement for maintainability. The changes look good. I've added a couple of minor suggestions to sort the new alias lists alphabetically to further improve readability.
| sig-community-reviewers: | ||
| - 3pointer | ||
| - GMHDBJD | ||
| - Joyinqin | ||
| - KanShiori | ||
| - Yisaer | ||
| - amyangfei | ||
| - anotherrachel | ||
| - aylei | ||
| - crazycs520 | ||
| - dveeden | ||
| - ericsyh | ||
| - glkappe | ||
| - junlan-zhang | ||
| - lucklove | ||
| - lysu | ||
| - ngaut | ||
| - superlzs0476 | ||
| - tiancaiamao | ||
| - weekface | ||
| - zimulala | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and easier maintenance, it's a good practice to keep lists of usernames sorted alphabetically. The previous OWNERS file had sorted lists, so it would be good to maintain that convention.
  sig-community-reviewers:
    - 3pointer
    - amyangfei
    - anotherrachel
    - aylei
    - crazycs520
    - dveeden
    - ericsyh
    - glkappe
    - GMHDBJD
    - Joyinqin
    - junlan-zhang
    - KanShiori
    - lucklove
    - lysu
    - ngaut
    - superlzs0476
    - tiancaiamao
    - weekface
    - Yisaer
    - zimulala
| sig-community-approvers: | ||
| - Icemap | ||
| - Oreoxmt | ||
| - breezewish | ||
| - csuzhangxc | ||
| - hfxsd | ||
| - jackysp | ||
| - kissmydb | ||
| - lance6716 | ||
| - lilin90 | ||
| - overvenus | ||
| - qiancai | ||
| - tangenta | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and easier maintenance, it's a good practice to keep lists of usernames sorted alphabetically. The previous OWNERS file had sorted lists, so it would be good to maintain that convention.
  sig-community-approvers:
    - breezewish
    - csuzhangxc
    - hfxsd
    - Icemap
    - jackysp
    - kissmydb
    - lance6716
    - lilin90
    - Oreoxmt
    - overvenus
    - qiancai
    - tangenta
Check List
Tests