Skip to content

*: add more unit tests #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 7, 2025
Merged

*: add more unit tests #2789

merged 15 commits into from
Nov 7, 2025

Conversation

@wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Oct 23, 2025

What problem does this PR solve?

Issue Number: ref #758

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 23, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 23, 2025
@wk989898
Copy link
Collaborator Author

wk989898 commented Oct 23, 2025

/test pull-unit-test

@wk989898 wk989898 marked this pull request as ready for review November 6, 2025 10:49
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 7, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-07 06:12:01.028493653 +0000 UTC m=+423370.471523522: ☑️ agreed by asddongmen.
  • 2025-11-07 06:37:55.240836188 +0000 UTC m=+424924.683866067: ☑️ agreed by 3AceShowHand.

tenfyzhong
tenfyzhong reviewed Nov 7, 2025
View reviewed changes
pkg/orchestrator/reactor_state_test.go
Copy link
Collaborator

@tenfyzhong tenfyzhong Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we delete this file?

Copy link
Collaborator Author

@wk989898 wk989898 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe fix it in the future

Copy link
Collaborator

@tenfyzhong tenfyzhong Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tenfyzhong
Copy link
Collaborator

tenfyzhong commented Nov 7, 2025

/test next-gen

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen, tenfyzhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen,tenfyzhong]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wk989898
Copy link
Collaborator Author

wk989898 commented Nov 7, 2025

/retest

1 similar comment
@wk989898
Copy link
Collaborator Author

wk989898 commented Nov 7, 2025

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 7, 2025 •
edited
Loading

@wk989898: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-next-gen 54c7baa link false /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit a9f3660 into pingcap:master Nov 7, 2025
18 of 19 checks passed
@wk989898 wk989898 deleted the ut branch November 7, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tenfyzhong tenfyzhong tenfyzhong approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@asddongmen asddongmen asddongmen approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wk989898 @tenfyzhong @3AceShowHand @asddongmen