Skip to content

consumer: support storage consumer #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 6, 2025
Merged

consumer: support storage consumer #2882

merged 14 commits into from
Nov 6, 2025

Conversation

@wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Oct 29, 2025

What problem does this PR solve?

Issue Number: close #2185

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 29, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2025
@wk989898
Copy link
Collaborator Author

wk989898 commented Oct 29, 2025

/test all

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2025
@wk989898
Copy link
Collaborator Author

wk989898 commented Oct 30, 2025

/test pull-cdc-storage-integration-light

@wk989898
Copy link
Collaborator Author

wk989898 commented Oct 30, 2025

/test pull-cdc-storage-integration-light

@wk989898
Copy link
Collaborator Author

wk989898 commented Oct 30, 2025

/test pull-cdc-storage-integration-heavy

@wk989898 wk989898 marked this pull request as ready for review November 4, 2025 03:03
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2025
@wk989898
Copy link
Collaborator Author

wk989898 commented Nov 4, 2025

/test all

@wk989898
Copy link
Collaborator Author

wk989898 commented Nov 4, 2025

/test all

@wk989898
Copy link
Collaborator Author

wk989898 commented Nov 4, 2025

/test pull-cdc-kafka-integration-heavy

@wk989898
Copy link
Collaborator Author

wk989898 commented Nov 5, 2025

/test all

@wk989898
Copy link
Collaborator Author

wk989898 commented Nov 5, 2025

/retest

@wk989898
Copy link
Collaborator Author

wk989898 commented Nov 5, 2025

/test pull-cdc-kafka-integration-heavy

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 5, 2025
@hongyunyan
Copy link
Collaborator

hongyunyan commented Nov 6, 2025

/test pull-cdc-storage-integration-light

@hongyunyan
Copy link
Collaborator

hongyunyan commented Nov 6, 2025

/test pull-cdc-storage-integration-heavy

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 6, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-05 11:46:03.65023146 +0000 UTC m=+270613.093261329: ☑️ agreed by 3AceShowHand.
  • 2025-11-06 03:33:24.432268447 +0000 UTC m=+327453.875298325: ☑️ agreed by hongyunyan.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, flowbehappy, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,flowbehappy,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wk989898
Copy link
Collaborator Author

wk989898 commented Nov 6, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit b1e969d into pingcap:master Nov 6, 2025
16 checks passed
@wk989898 wk989898 deleted the storage-consumer branch November 6, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@hongyunyan hongyunyan hongyunyan approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

introduce new storage consumer based on the mysql sink

4 participants

@wk989898 @hongyunyan @flowbehappy @3AceShowHand