feat: added terminal docking to right#1774
feat: added terminal docking to right#1774atmikshetty wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review This PR adds a new user-facing feature (terminal docking to the right side) with new state management, storage migration, and UI changes across multiple components. New features introducing new behavior warrant human review regardless of implementation quality. You can customize Macroscope's approvability policy. Learn more. |
What Changed
Why
UI Changes
Terminal Docked to the right:

Works when the app is minimised as well:

Redocking back to below the chat:

Small Video showing the full change:
https://github.com/user-attachments/assets/3a6f0f84-5040-4dd1-b139-7c2e94650050
Checklist
Note
Medium Risk
Medium risk: changes terminal layout/resizing behavior and persisted terminal state (including a storage migration), plus adds a dev-time Electron auto-install fallback that could affect launcher startup if it misfires.
Overview
Adds per-thread terminal docking so the thread terminal can live either below the chat or on the right, including a new toolbar toggle and right-docked resize behavior (width, split layout orientation, and clamping).
Persists new terminal metadata (
terminalDock,terminalWidth) interminalStateStorewith a storage version bump + migration/normalization for older snapshots, and updatesChatViewto render right-docked terminals inside the main layout while bottom-docked terminals remain below. Also updates tests to cover docking/width behavior.Separately, the desktop
electron-launchernow detects the "Electron failed to install correctly" case and attempts to run Electron’sinstall.jsautomatically, and markselectronas a trusted dependency inpackage.json.Reviewed by Cursor Bugbot for commit ebf80aa. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add right-side terminal docking with adjustable width to the terminal drawer
ThreadTerminalDrawergains a right-dock mode alongside the existing bottom-dock mode, with a toggle in the UI and horizontal drag-to-resize support.ThreadTerminalStateis extended withterminalDockandterminalWidthfields; the store bumps its persistence version to 2 and migrates legacy state to apply defaults (bottomdock, 420px width).ChatViewrenders right-docked terminal drawers inside the main horizontal flex area and bottom-docked drawers below it, using normalized state fromselectThreadTerminalStateto determine which threads have open terminals.terminalDocktobottomandterminalWidthto 420 if not already present.Macroscope summarized ebf80aa.