Skip to content

feat: added terminal docking to right#1774

Open
atmikshetty wants to merge 1 commit intopingdotgg:mainfrom
atmikshetty:feat/terminal-right-dock
Open

feat: added terminal docking to right#1774
atmikshetty wants to merge 1 commit intopingdotgg:mainfrom
atmikshetty:feat/terminal-right-dock

Conversation

@atmikshetty
Copy link
Copy Markdown

@atmikshetty atmikshetty commented Apr 6, 2026

What Changed

  • Added a terminal dock toggle button next to the existing split terminal action in the thread terminal toolbar.
  • Terminals can now be docked either:
    • below the chat view, or
    • on the right side of the chat view.
  • Terminal dock position and right-dock width are persisted per thread.

Why

  • The terminal could previously only be docked below the chat view, which limited layout flexibility and made it harder to use alongside the conversation in wider desktop layouts.
  • The change fixes that by allowing the terminal to be docked to the right.
  • Also, the dock state persists, so users won't have to manually do it every time they open the app.

UI Changes

Terminal Docked to the right:
image

Works when the app is minimised as well:
image

Redocking back to below the chat:
image

Small Video showing the full change:
https://github.com/user-attachments/assets/3a6f0f84-5040-4dd1-b139-7c2e94650050

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Medium risk: changes terminal layout/resizing behavior and persisted terminal state (including a storage migration), plus adds a dev-time Electron auto-install fallback that could affect launcher startup if it misfires.

Overview
Adds per-thread terminal docking so the thread terminal can live either below the chat or on the right, including a new toolbar toggle and right-docked resize behavior (width, split layout orientation, and clamping).

Persists new terminal metadata (terminalDock, terminalWidth) in terminalStateStore with a storage version bump + migration/normalization for older snapshots, and updates ChatView to render right-docked terminals inside the main layout while bottom-docked terminals remain below. Also updates tests to cover docking/width behavior.

Separately, the desktop electron-launcher now detects the "Electron failed to install correctly" case and attempts to run Electron’s install.js automatically, and marks electron as a trusted dependency in package.json.

Reviewed by Cursor Bugbot for commit ebf80aa. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add right-side terminal docking with adjustable width to the terminal drawer

  • ThreadTerminalDrawer gains a right-dock mode alongside the existing bottom-dock mode, with a toggle in the UI and horizontal drag-to-resize support.
  • ThreadTerminalState is extended with terminalDock and terminalWidth fields; the store bumps its persistence version to 2 and migrates legacy state to apply defaults (bottom dock, 420px width).
  • ChatView renders right-docked terminal drawers inside the main horizontal flex area and bottom-docked drawers below it, using normalized state from selectThreadTerminalState to determine which threads have open terminals.
  • Split-pane grid orientation and terminal viewport fitting now adapt based on dock position.
  • Behavioral Change: existing users' persisted terminal state is migrated on load, setting terminalDock to bottom and terminalWidth to 420 if not already present.

Macroscope summarized ebf80aa.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4e4a47e3-0b6b-43a4-b216-0ab568f56661

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Apr 6, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 6, 2026

Approvability

Verdict: Needs human review

This PR adds a new user-facing feature (terminal docking to the right side) with new state management, storage migration, and UI changes across multiple components. New features introducing new behavior warrant human review regardless of implementation quality.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant