Don't truncate commands + show running commands#1775
Don't truncate commands + show running commands#1775Minigamer42 wants to merge 2 commits intopingdotgg:mainfrom
Conversation
- Stop truncating `detail` when ingesting provider runtime tool events
- carry item IDs and payload data through server ingestion - collapse tool lifecycle rows by stable item IDs - keep command start rows visible with clearer labels
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b042087. Configure here.
ApprovabilityVerdict: Needs human review This PR modifies runtime behavior for command display (removes truncation, adds 'Running' state indication) with non-trivial changes to work log collapsing logic. An open review comment identifies a potential bug where lifecycle-dependent titles could prevent proper collapsing of started/completed entries when itemId is absent. You can customize Macroscope's approvability policy. Learn more. |

What Changed
truncateDetailcall for tool calls send by the agent (the output is still truncated via css ellipsis in the UI, but can be viewed by hovering)Why
UI Changes
https://www.youtube.com/watch?v=SJUpSWBkfUk
Checklist
Note
Medium Risk
Changes tool lifecycle event payloads and client-side collapsing logic, which could increase event payload size and alter how work-log rows merge/render during active turns.
Overview
Improves tool/command visibility in the timeline by preserving full
detailfortool.started/tool.completedevents (no server-side truncation) and by attachingitemIdto tool lifecycle activity payloads so entries can be reliably correlated end-to-end.Updates Codex runtime mapping to label
command_executionas "Running command" on start, and updates the web work-log derivation to include running command rows while collapsing started/updated/completed events using a stablecollapseKey(preferringitemId) so lifecycle rows merge correctly even when events aren’t adjacent.Reviewed by Cursor Bugbot for commit b042087. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Show running commands in chat and stop truncating command detail
tool.startedevents forcommand_executionitems are now included in the work log (previously alltool.startedevents were filtered out), displaying a "Running command" title while in progress and "Ran command" on completion.detailpayloads are no longer truncated intool.startedandtool.completedactivities in ProviderRuntimeIngestion.ts.collapseKey(preferringitemId) across non-adjacent entries, replacing the previous immediate-predecessor-only approach.collapseKeyoverid, which may alter component reuse during updates.collapseKey, andtool.startedfor non-command items remains filtered out.Macroscope summarized b042087.