Skip to content

Conversation

@feyyazcigim
Copy link
Contributor

This pull request adds a context menu feature to the Market page, enabling users to right-click or click on empty space in the scatter chart to quickly create orders or listings with prefilled values. It also refactors the chart click handling to provide richer payloads and updates the CreateOrder and CreateListing pages to accept and process prefilled form values. The main changes are grouped below:

Market chart context menu feature:

  • Added a new ContextMenu component (src/components/MarketContextMenu.tsx) that displays options at the click location and closes on outside click or Escape.
  • Updated the Market page (src/pages/Market.tsx) to show the context menu when the user clicks on empty space in the scatter chart, passing clicked coordinates, and to handle option selection for creating orders or listings with prefilled values. [1] [2] [3] [4]

Chart click payload improvements:

  • Refactored ScatterChart to emit a PointClickPayload object on click, containing chart coordinates, scale ranges, and active element info if a data point is clicked. Updated the chart interaction mode to improve point detection and click handling. [1] [2] [3] [4]

Prefill support in order/listing creation flows:

  • Updated CreateOrder and CreateListing pages to accept prefill values via React Router location state, and automatically fill form fields (price, place in line, expiration) when arriving from the context menu. Cleans up location state after use. [1] [2] [3] [4] [5] [6]

Miscellaneous chart improvements:

  • Improved chart axis rounding and scale calculations for better tick generation and logarithmic support.
  • Fixed plugin memoization dependencies for chart mouseover and selection callbacks. [1] [2]

@netlify
Copy link

netlify bot commented Oct 16, 2025

Deploy Preview for pintomoney ready!

Name Link
🔨 Latest commit 7a53884
🔍 Latest deploy log https://app.netlify.com/projects/pintomoney/deploys/68febe03ec620b0008c3d661
😎 Deploy Preview https://deploy-preview-292--pintomoney.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fr1jo
Copy link
Contributor

fr1jo commented Oct 24, 2025

copying feedback for @burr-nim's visibility:

remaining features to add:

  1. When hovering around, the golden text for the price per pod and place in line should always be active. When writing user facing software, we should be mindful of what we're building - if a Farmer is trying to place an order/listing on the site via clicking on a point on the graph, they want the info (price per pod/ place in line) prior to clicking, rather than clicking after. Ultimately the goal is to create a great user experience for people purchasing pods.

  2. Once the user has clicked on a point, the crosshair should not move anymore. This enforces the idea of the user making a decision. Having the crosshair follow the mouse at this point is a little confusing imo

  3. When the user hovers over a pod listing, the vertical gray line should not be visible (since we see the dark line already).

  4. currently, when a user hovers over one pod listing, and then another pod listing, there is a sliding animation that slides from the last point to the new point. This made more sense when the order was always active until the farmer moved to a new order, but given that we've changed the flow, the animation should be a simple fade in now.

  5. a small drop down animation here would be very useful for a smooth UX. having the context menu "pop" in is very jarring and comes out of nowhere.

Otherwise, this is heading in the right direction. Good work.

@fr1jo
Copy link
Contributor

fr1jo commented Nov 5, 2025

closed in favor of #303

@fr1jo fr1jo closed this Nov 5, 2025
@feyyazcigim feyyazcigim reopened this Dec 11, 2025
@feyyazcigim feyyazcigim changed the base branch from main to development December 11, 2025 13:31
@feyyazcigim feyyazcigim changed the base branch from development to marketplace-pi December 15, 2025 10:23
@feyyazcigim feyyazcigim merged commit 58d75d7 into pinto-org:marketplace-pi Dec 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants