-
Notifications
You must be signed in to change notification settings - Fork 357
Improve Client TLS Turn-Server Example, Update Usage Docs #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #520 +/- ##
==========================================
- Coverage 80.90% 80.74% -0.17%
==========================================
Files 46 46
Lines 3017 3017
==========================================
- Hits 2441 2436 -5
- Misses 364 368 +4
- Partials 212 213 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM @adrianosela nice work! Mind just adding |
|
Ack on my part, thanks! Just for the info: is this part of some sort of official/semi-official zero-trust TURN extension that I have missed? How do you plan to use this from clients? Should WebRTC clients/browsers just work given the right client TLS cert? |
No. When I proposed adding client TLS auth support I was looking for an open source traffic relay I could use for a VPN-like product I work on, completely outside of the context of WebRTC. Among other limitations, username and password auth was a no-go for us. In the end I ended up rolling a fully custom relay/protocol for WireGuard (UDP) over WebSockets. Its closed source unfortunately, so I can't share it. |
All done, rebased too. |
|
@adrianosela Would it be ok if I added you to the Pion org? No real commitment/responsibility. Your code + design skills are top notch and would be helpful to have you involved :) |
|
It would just let you review/merge PRs and I could use the help! |
|
Hey @Sean-Der, that sounds great. I've been using pion libraries for a long time and would be happy to help where I can. |
Description