Skip to content

Conversation

@israelcefrin
Copy link
Contributor

Fix the low contrast ratio in the date component.

@kaitlinnewson
Copy link
Member

Hi @israelcefrin, what if instead of using darkslategrey which isn't used in the theme, we instead applied the text-muted class to the date in templates/frontend/objects/issue_summary.tpl? Then we can remove this CSS class and use the existing bootstrap class which has a 4.69:1 contrast ratio and is already used elsewhere in the theme (e.g. for announcement dates).

@israelcefrin
Copy link
Contributor Author

Hi @kaitlinnewson, good call! I've already adjusted and submitted a new commit to use BootStrap class name. I haven't noticed we could use all BS framework.

@kaitlinnewson kaitlinnewson merged commit 1e560fc into pkp:stable-3_5_0 Oct 22, 2025
4 checks passed
kaitlinnewson pushed a commit that referenced this pull request Oct 22, 2025
* #103 Elements must meet minimum color contrast ratio

* #103 Elements must meet minimum color contrast ratio - remove old class to use bootstrap class
@kaitlinnewson kaitlinnewson linked an issue Oct 22, 2025 that may be closed by this pull request
@kaitlinnewson
Copy link
Member

Thanks @israelcefrin! Merged and cherry-picked to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[A11Y] Elements must meet minimum color contrast ratio thresholds

2 participants