feat(theme): add fadeout option for article abstracts on issue pages #156
Conversation
Add new 'fadeoutAbstracts' display option for article abstracts on issue pages. Also refactor template checks to use array and simplify conditional assignment.
|
Hi @Godoy0722, I thought this feature was introduced previously in #122 - is there a bug being resolved with this PR or something not working with the feature as expected? Thanks! |
|
Hi everyone, I can provide context. The feature as is is not working properly. Regardless of what the setting is in the interface, the article abstract is always displayed. We believe it is because of the way this comparison is being made. |
|
Thanks for the additional details @jnugent - I'll give this a more thorough test with the changes to confirm the fix as well. Just a couple of minor comments on the PR @Godoy0722 then I can merge and will forward-port to 3.5/main. |
|
Tested and confirmed this works with the three different abstract settings - @Godoy0722 just a couple of comments above to address then I can get this merged and released. |
|
Hello all! Sorry for the late response! I'll have a look on it as soon as possible and answer all your questions @kaitlinnewson . Thanks for leting me know! I'll reach out here until tomorrow when I have reviewed it. |
Explicity setting a boolean condition. Suggested by kaitlin and commited by guilherme Co-authored-by: Kaitlin Newson <kaitlin.newson@gmail.com>
…and remove the conditional class assignment in the template for cleaner code.
…ersion into ggodoy-abstract_correction
3 participants
Add new 'fadeoutAbstracts' display option for article abstracts on issue pages. Also refactor template checks to use array and simplify conditional assignment.