Open
Conversation
minnce
approved these changes
Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General things:
What is the purpose of this PR?
Bugfix in riskTracker.cpp
What changes did you make? Why?
Fixed the erroneous cumulative calculation of total risk once calling updateRisk()
What bugs did you find while testing?
Repeated calculation of total risk once calling updateRisk()
This PR Specific:
What was the bug you found?
Repeated calculation of total risk once calling updateRisk()
How did you address it?
Fixed the erroneous cumulative calculation of total risk once calling updateRisk(); Changed operation += into =
What did you struggle with?
Is there anything you would change about this step?