Adding feature to return current waypoint index #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

christomaszewski wants to merge 6 commits into master from feature/get_waypoints_index

Member

christomaszewski commented Apr 26, 2017

Needs testing.


          Trying to add a new function that returns an integer. NOT FUNCTIONAL …

07f8cce

…- fails a test.

christomaszewski requested a review from psigen

April 26, 2017 15:03

Contributor

jjblum commented Apr 26, 2017 •

edited

Loading

Okay, so if you build with dependencies in netbeans, it passes all the tests. If you don't, it fails a test or two. I did test this in the field with the core lib jar built with dependenices and it functions as intended. So i'm not sure how to classify it. The "NOT FUNCTIONAL" commit message isn't correct, at least. I tried to update the commit message, but my git-fu was too weak.


          No changes from last commit. It is actually functional, it just had t…

50314b3

…o be compiled with dependencies to pass the tests.

Contributor

jjblum commented May 10, 2017

Why would my update cause this test to fail:

/**
 * Test of isConnected method, of class UdpVehicleServer.
 */
@Test
public void testIsConnected() {
    UdpVehicleServer instance = new UdpVehicleServer(serviceAddress);
    VehicleServer server = AsyncVehicleServer.Util.toSync(instance);

    // Since we are using a test server, it should always be connected
    assertTrue("Server claimed it was not connected", server.isConnected());
}

Member

psigen commented May 11, 2017

It might be a race condition in the test code networking that just makes it fail at random. We can rerun the test and if it passes, it should be good.

shantanu-vyas self-requested a review

June 13, 2017 20:21

christomaszewski commented

View reviewed changes

src/main/java/com/platypus/crw/AsyncVehicleServer.java Outdated

    
                  public void captureImage(int width, int height, FunctionObserver<byte[]> obs);

                      public void addCameraListener(CameraListener l, FunctionObserver<Void> obs);

                  public void addCameraListener(CameraListener l, FunctionObserver<Void> obs);

Member Author

christomaszewski Jun 13, 2017

fix indent

src/main/java/com/platypus/crw/AsyncVehicleServer.java Outdated

    
              	public void addImageListener(ImageListener l, FunctionObserver<Void> obs);

              	public void removeImageListener(ImageListener l, FunctionObserver<Void> obs);

                      public void captureImage(int width, int height, FunctionObserver<byte[]> obs);

                  public void captureImage(int width, int height, FunctionObserver<byte[]> obs);

Member Author

christomaszewski Jun 13, 2017

fix indent

Contributor

jjblum Jun 13, 2017

looking at the file now, the indent is not right after your fix either.

src/main/java/com/platypus/crw/AsyncVehicleServer.java Outdated

    
                      public void isConnected(FunctionObserver<Boolean> obs);

                      public void isAutonomous(FunctionObserver<Boolean> obs);

                  public void isConnected(FunctionObserver<Boolean> obs);

                  public void isAutonomous(FunctionObserver<Boolean> obs);

Member Author

christomaszewski Jun 13, 2017

fix the damn indents

src/main/java/com/platypus/crw/AsyncVehicleServer.java Outdated

    
              	public void getVelocity(FunctionObserver<Twist> obs);

                      public void addWaypointListener(WaypointListener l, FunctionObserver<Void> obs);

                  public void addWaypointListener(WaypointListener l, FunctionObserver<Void> obs);

Member Author

christomaszewski Jun 13, 2017

fix indent

src/main/java/com/platypus/crw/AsyncVehicleServer.java Outdated

    
              	public void stopWaypoints(FunctionObserver<Void> obs);

              	public void getWaypoints(FunctionObserver<UtmPose[]> obs);

              	public void getWaypointStatus(FunctionObserver<WaypointState> obs);

                  public void getWaypointsIndex(FunctionObserver<Integer> obs);

Member Author

christomaszewski Jun 13, 2017

fix indent

src/main/java/com/platypus/crw/AsyncVehicleServer.java Outdated

    
                      public void isConnected(FunctionObserver<Boolean> obs);

                      public void isAutonomous(FunctionObserver<Boolean> obs);

                  public void isConnected(FunctionObserver<Boolean> obs);

Member Author

christomaszewski Jun 13, 2017

fix indent

jjblum and others added 4 commits

June 13, 2017 23:24


          fixing indents

7dda856


          Create AsyncVehicleServer.java

a5a69b2

Fixing indents for real


          Switched to tabs

7f109b7


          Emacs backup files needs to be deleted

8e2a489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet