Draft
Conversation
zoldar
force-pushed
the
e2e-feature-tests-redux
branch
7 times, most recently
from
0048ba5 to
31a780d
Compare
zoldar
force-pushed
the
e2e-feature-tests-redux
branch
3 times, most recently
from
a4c013a to
cf12212
Compare
zoldar
force-pushed
the
e2e-feature-tests-redux
branch
from
46d7059 to
45cedd6
Compare
zoldar
force-pushed
the
e2e-feature-tests-redux
branch
from
45cedd6 to
fd006c0
Compare
zoldar
force-pushed
the
e2e-feature-tests-redux
branch
from
34cd651 to
b033f89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR extends previously setup E2E test suite to cover major extent of dashboard interactions. There are still some aspects that are not covered yet, like:
Also, we don't cover all the possible states, mostly focusing on "happy" paths.
The missing coverage will be added in follow-ups as this PR is already huge. We might add more tests for less usual interaction paths but we will have to strike a balance to avoid inflating the test suite and slowing down the CI pipeline too much.
The top level tests number is kept relatively low (currently between 40-50) as state setup is usually the expensive part of the process. We might replacing frontend-centric fixtures setting up user and site via forms on the page with dedicated e2e endpoints in the future to reduce the time spent on it if that becomes too much of a burden (we might still keep the existing fixtures and use them only for a couple general tests to keep covering areas outside the dashboard by extension). We make extensive use of
test.stepto cram more test cases in each test. This means there are effectively more test cases than the report implies.Tests