-
Notifications
You must be signed in to change notification settings - Fork 16
Changes theme to pydata-sphinx-theme #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
billbrod
wants to merge
19
commits into
main
Choose a base branch
from
pydata-sphinx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
look through all markdown files in docs, and grab those that start with jupytext header (since they don't all live in the same folder now)
- can navigate between sections using prev/next (because of hidden toctree) - hides primary sidebar for all API docs pages - hides secondary sidebar for synthesis objects (since they only contain the one object) - synthesis objects just use name instead of fullname (which shows module path)
and unhides toctree
won't add in this PR, because version_switcher.json needs to be in main first
Member
Author
|
Documentation built by flatiron-jenkins at http://docs.plenoptic.org/docs//pulls/410 |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change in this PR at a high-level
This PR changes our sphinx theme to pydata-sphinx-theme. It also reorganizes the documentation inline with the suggestions from the pyOpenSci review.
NOTE: Failing url is expected and won't change in this PR. For pydata theme's version switcher, we need to point to a json that lives at a persistent url (i.e., not within the docs folder) so that the version switcher can get updated with new versions as they get released without rebuilding old documentation. I have put a first draft of that json in this PR, but the url that version switcher points to won't work until after this PR is merged (because it's pointing to the built docs from the main branch). I'm now realizing I could include the json but not configure the switcher in this PR (since I haven't added the switcher to the theme anyway) -- what do you think?
Link any related issues, discussions, PRs
Closes #360, #21.
Related open issues, will address these later:
Also, the names of some of the API pages are really long. As part of #246 , I will be changing how things are named and fix this.
Outstanding questions / particular feedback
CONTRIBUTING.mdin main repo todocs/developers/contributing.mdtoctrees. This has led to the creation of many more index pages (e.g.,getting_started/index). I'm not really sure what to put there -- how do they look? For "Getting Started", "User Guide", "Reference", and "For developers", I put a brief summary of the contents of that section. For the more nested ones (all the sections within "Getting Started"), I just had them show the full toctree.docs/api_modules.rstpage. In order to make it so you can use the next/previous buttons at the bottom to navigate between them, I had to add a single hidden toctree inapi.rstwhich includes all of the pages.api_modules.rst, but then that page (which I don't want people to look at) gets included in the hierarchy and looks weird. And I can't just include the contents ofapi_modules.rstinapi.rstbecause there's no way to hide aautosummarylike atoctree.linting/, but is there something else I'm missing?object.method(e.g.,loadinstead ofMetamer.load), but I couldn't figure out how to do that with the theme.Describe changes
Checklist
Affirm that you have done the following:
docs/, or (for large changes) adding new files to thedocs/folder.docs/api.rstanddocs/api_modules.rstto include it if necessary.