Recurrence additionaldates

[thet]

feat(pat-recurrence): Allow to enable/disable the feature to add additional dates.

Ref:
plone/plone.formwidget.recurrence#66
plone/plone.formwidget.recurrence#49
plone/plone.formwidget.recurrence#48

Does two things:

fix(pat-recurrence): In an error case when loading the occurrences preview, show a inline warning instead of a window alert.

before:

after:

feat(pat-recurrence): Allow to enable/disable the feature to add additional dates.

Without (default):

With:

TBD

• I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
• I verified there aren't any other open pull requests for the same change.
• I followed the guidelines in Contributing to Plone.
• I successfully ran code quality checks on my changes locally.
• I successfully ran tests on my changes locally.
• If needed, I added new tests for my changes.
• If needed, I added documentation for my changes.
• I included a change log entry in my commits.

---

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

[petschki]

LGTM

[petschki]

For me allowAdditionalDates woud make more sense, as its in line with the z3c.form widget property.

[thet]

I changed to hasAdditionalDates as we already have hasRepeatForeverButton. But is there already a z3c.form widget property which is named allowAdditionalDates? I thought that was introduced in plone/plone.formwidget.recurrence#66

[petschki]

No there isn't. I just wanted to be them in sync.

[petschki]

btw. were the latest two commits on master regarding recurrence widget intended to be in this PR? https://github.com/plone/mockup/commits/master/

[thet]

@petschki no, I intentionally left them out of this PR, otherwise reviewing would be hard. This autoformatting did not change anything in the logic, it was just prettifying the code.

@petschki what is your opinion again on hasAdditionalDates vs allowAdditionalDates?‌
The allowAdditionalDates was invented in the plone/plone.formwidget.recurrence#66 without a counterpart in mockup, so IMO we can change it in the other PR too. It's a question on consistency vs clearer naming.

[petschki]

so the translated strings are all provided via the plone.formwidget.recurrence template markup right? This should be implemented there too.

[petschki]

https://github.com/plone/plone.formwidget.recurrence/blob/master/src/plone/formwidget/recurrence/browser/i18n.py

[petschki]

@petschki no, I intentionally left them out of this PR, otherwise reviewing would be hard. This autoformatting did not change anything in the logic, it was just prettifying the code.

@petschki what is your opinion again on hasAdditionalDates vs allowAdditionalDates?‌ The allowAdditionalDates was invented in the plone/plone.formwidget.recurrence#66 without a counterpart in mockup, so IMO we can change it in the other PR too. It's a question on consistency vs clearer naming.

my personal opinion: I want to allow adding additional dates or not ... so allowAdditionalDates would be my favorite.