Skip to content

Conversation

@stevepiercy
Copy link
Contributor

@stevepiercy stevepiercy commented Dec 17, 2025

When building make livehtml, the directory /_build contains the built documentation. It was not getting ignored in git. This PR fixes that issue.


📚 Documentation preview 📚: https://ploneapi--598.org.readthedocs.build/

@mister-roboto
Copy link

@stevepiercy thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@stevepiercy
Copy link
Contributor Author

Nah, I'm good Jenkins. No need to run for this trivial fix.

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we should add to the default .gitignore in plone/meta?

@github-project-automation github-project-automation bot moved this from In Progress to Approved in Plone Documentation Dec 17, 2025
@stevepiercy
Copy link
Contributor Author

I guess so? Most of the repos I fiddle with don't use meta. I don't think it'll hurt anything.

@mauritsvanrees mauritsvanrees merged commit 390d3ac into main Dec 18, 2025
11 of 13 checks passed
@mauritsvanrees mauritsvanrees deleted the ignore-_build-from-make-livehtml branch December 18, 2025 11:02
@github-project-automation github-project-automation bot moved this from Approved to Done in Plone Documentation Dec 18, 2025
@mauritsvanrees
Copy link
Member

GHA will be broken for a bit, but I am making releases to fix that.

@mauritsvanrees
Copy link
Member

GHA will be broken for a bit, but I am making releases to fix that.

Sorry, wrong tab, this comment is for a different PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants