-
-
Notifications
You must be signed in to change notification settings - Fork 59
Configure .meta.toml to ignore the _build directory for docs #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@stevepiercy thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
Nah, I'm good Jenkins. No need to run for this trivial fix. |
davisagli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we should add to the default .gitignore in plone/meta?
|
I guess so? Most of the repos I fiddle with don't use meta. I don't think it'll hurt anything. |
|
GHA will be broken for a bit, but I am making releases to fix that. |
Sorry, wrong tab, this comment is for a different PR. |
When building
make livehtml, the directory/_buildcontains the built documentation. It was not getting ignored in git. This PR fixes that issue.📚 Documentation preview 📚: https://ploneapi--598.org.readthedocs.build/