Fix #667

[szakitibi]

Remove dangerous default default=[]

[mister-roboto]

@szakitibi you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

[mister-roboto]

@szakitibi thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

[szakitibi]

Regarding "Plone Contributors Agreement verifier":

Plone Release Manager, the patch is so tiny as not to constitute a "creative work."

I'm hereby transfer the intellectual property rights to the Plone Foundation for this PR.

[mauritsvanrees]

I don't think the default=[] is actually a problem here. This is not a function definition.
Ah, the document you point to does say it is a problem.

@pbauer Since you introduced this default in PR #642 last year, could you check if this PR is okay? Issue #667 has some links.

Regarding "Plone Contributors Agreement verifier":

Plone Release Manager, the patch is so tiny as not to constitute a "creative work."

I'm hereby transfer the intellectual property rights to the Plone Foundation for this PR.

Since this PR only removes a line, I am happy to accept it as release manager.

[petschki]

Maybe it should be missing_value=[] ?