Skip to content

Include vocabulary token #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackahl wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Include vocabulary token #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bb2c43
include token in vocabulary terms
jackahl May 4, 2022
9c604ff
update changelog
jackahl May 4, 2022
12ad333
fix changelog entry
jackahl May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/106.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
include vocabulary term token in termlist used to configure the querystring search [jackahl] (#106)
6 changes: 3 additions & 3 deletions plone/app/querystring/registryreader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,13 @@ def getVocabularyValues(self, values):
title = translate(item.title, context=self.request)
else:
title = item.title
translated.append((title, item.value))
translated.append((title, item.value, item.token))
translated = sorted(
translated,
key=lambda x: normalizeString(safe_unicode(x[0]))
)
for (title, value) in translated:
field['values'][value] = {'title': title}
for (title, value, token) in translated:
field['values'][value] = {'title': title, 'token': token}

return values

Expand Down
2 changes: 1 addition & 1 deletion plone/app/querystring/tests/testRegistryReader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def test_get_vocabularies(self):
result = reader.getVocabularyValues(result)
vocabulary_result = result.get(
'plone.app.querystring.field.reviewState.values')
self.assertEqual(vocabulary_result, {'foo': {'title': u'bar'}})
self.assertEqual(vocabulary_result, {'foo': {'title': u'bar', 'token': 'foo'}})

def test_map_operations_clean(self):
"""tests if mapOperations is getting all operators correctly"""
Expand Down