BUILDING: cunit is a runtime dependency, not optional

[grahamperrin]

Observed with FreeBSD 15.0-RELEASE-p4.

[grahamperrin]

grahamperrin@clean:~/dev/plp13/qman % meson setup build/
The Meson build system
Version: 1.7.0
Source dir: /home/grahamperrin/dev/plp13/qman
Build dir: /home/grahamperrin/dev/plp13/qman/build
Build type: native build
Project name: qman
Project version: 1.5.1
C compiler for the host machine: cc (clang 19.1.7 "FreeBSD clang version 19.1.7 (https://github.com/llvm/llvm-project.git llvmorg-19.1.7-0-gcd708029e0b2)")
C linker for the host machine: cc ld.lld 19.1.7
Host machine cpu family: x86_64
Host machine cpu: x86_64
Program cog found: YES (/usr/local/bin/cog)
Found pkg-config: YES (/usr/local/bin/pkg-config) 2.4.3
Run-time dependency ncursesw found: YES 6.5.20240427
Run-time dependency zlib found: YES 1.3.1
Run-time dependency bzip2 found: YES 1.0.8
Run-time dependency liblzma found: YES 5.8.1
Found CMake: /usr/local/bin/cmake (3.31.10)
Run-time dependency cunit found: NO (tried pkgconfig and cmake)

src/meson.build:66:10: ERROR: Dependency "cunit" not found, tried pkgconfig and cmake

A full log can be found at /home/grahamperrin/dev/plp13/qman/build/meson-logs/meson-log.txt
grahamperrin@clean:~/dev/plp13/qman % freebsd-version -kru ; uname -mvKU
15.0-RELEASE-p4
15.0-RELEASE-p4
15.0-RELEASE-p4
FreeBSD 15.0-RELEASE-p4 releng/15.0-n281010-8ef0ed690df2 GENERIC amd64 1500068 1500068
grahamperrin@clean:~/dev/plp13/qman %

[plp13]

Hi @grahamperrin,

cunit is an optional dependency, and won't be used if you disable tests using meson setup build -Dtest=disabled.

That said, the documentation could be clearer on which meson options affect each dependency. Perhaps something like:

Optional dependencies

• cuinit: used for unit testing (disable with -Dtests=disabled)

Similar wording should, of course, be provided for all other optional dependencies.

Also, it seems that the Meson options section is missing a reference to libbsd:

Meson options

• -Dlibbsd=enabled: link against libbsd (required when using older versions of libc on Linux)

I don't think that any of the above docs improvements is critical enough to merit new minor version for Qman, though. So, they should really go into devel and become part of the next major version.

See https://github.com/plp13/qman/blob/main/doc/CONTRIBUTING.md