Skip to content

Fix - Restore inline editing functionality in items tab #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 29, 2025
Merged

Fix - Restore inline editing functionality in items tab #488

merged 4 commits into from
Oct 29, 2025
+286 −14

Conversation

@RomainLvr
Copy link
Contributor

@RomainLvr RomainLvr commented Oct 28, 2025 •
edited by Rom1-B
Loading

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • [] I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !39919
  • Here is a brief description of what this PR does

Problem

Inline editing of quantities, prices, and discounts in the "Order Items" tab was lost during the Twig migration in PR #417. Users could no longer click on values to edit them directly.

Solution

  • Added editable formatters (editable_price, editable_discount, editable_quantity) to the Twig template
  • Implemented JavaScript functions for inline editing with proper Ajax integration
  • Fixed function naming conflicts between summary and detail tables
  • Resolved massive action compatibility issues

Screenshots (if appropriate):

Capture vidéo du 2025-10-28 10-38-50

@RomainLvr RomainLvr requested review from Lainow and Rom1-B October 28, 2025 09:40
@RomainLvr RomainLvr self-assigned this Oct 28, 2025
Rom1-B
Rom1-B requested changes Oct 28, 2025
View reviewed changes
@RomainLvr RomainLvr requested a review from Rom1-B October 28, 2025 10:43
Rom1-B
Rom1-B requested changes Oct 28, 2025
View reviewed changes
@RomainLvr RomainLvr requested a review from Rom1-B October 28, 2025 13:54
@Rom1-B Rom1-B merged commit e5e92d1 into 10.0/bugfixes Oct 29, 2025
3 checks passed
@Rom1-B Rom1-B deleted the fix/inline-editing-regression branch October 29, 2025 07:37
Rom1-B pushed a commit that referenced this pull request Oct 29, 2025
@RomainLvr @Rom1-B
Fix - Restore inline editing functionality in items tab (#488)
fc8f87a 
* Fix - Restore inline editing functionality in items tab

* Apply suggestions

* Apply suggestions

* Update CHANGELOG & optimize style

(cherry picked from commit e5e92d1)
RomainLvr added a commit that referenced this pull request Oct 29, 2025
@RomainLvr
Fix - Restore inline editing functionality in items tab (#488)
328c6af 
* Fix - Restore inline editing functionality in items tab

* Apply suggestions

* Apply suggestions

* Update CHANGELOG & optimize style

(cherry picked from commit e5e92d1)
@RomainLvr RomainLvr mentioned this pull request Oct 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rom1-B Rom1-B Rom1-B approved these changes

@Lainow Lainow Lainow approved these changes

Assignees

@RomainLvr RomainLvr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RomainLvr @Rom1-B @Lainow