Skip to content

Load logo from Branding when activated#13

Merged
stonebuzz merged 13 commits intopluginsGLPI:mainfrom
RomainLvr:feat/use-branding-logo
Feb 24, 2025
Merged

Load logo from Branding when activated#13
stonebuzz merged 13 commits intopluginsGLPI:mainfrom
RomainLvr:feat/use-branding-logo

Conversation

@RomainLvr
Copy link

@RomainLvr RomainLvr commented Jan 15, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

image

image

image

@RomainLvr RomainLvr requested review from Rom1-B and stonebuzz January 15, 2025 14:10
@RomainLvr RomainLvr self-assigned this Jan 15, 2025
@stonebuzz stonebuzz self-requested a review January 15, 2025 14:53
@RomainLvr RomainLvr requested a review from stonebuzz January 15, 2025 16:16
@RomainLvr RomainLvr force-pushed the feat/use-branding-logo branch from 59b4c44 to 183bff3 Compare January 16, 2025 09:11
@stonebuzz stonebuzz self-requested a review January 16, 2025 10:02
Co-authored-by: Stanislas <skita@teclib.com>
@Rom1-B Rom1-B requested a review from stonebuzz February 4, 2025 09:16
@stonebuzz
Copy link

after internal discussion :

the Branding logo should not be loaded from the PDF plugin

PDF plugin must set up a HOOK, allowing the Branding plug-in to propose its logo.

You can take inspiration from this to create hook from PDF

https://github.com/pluginsGLPI/treeview/blob/1eb1f01bc74c947475344f6ede6f54032b887691/inc/config.class.php#L441

and this to use it from Branding

https://github.com/pluginsGLPI/genericobject/blob/ac3ece6378b4f050d4f2c2640acc4a395aab46eb/setup.php#L135-L162

@RomainLvr RomainLvr requested a review from stonebuzz February 20, 2025 14:30
@RomainLvr RomainLvr requested a review from Rom1-B February 21, 2025 16:54
RomainLvr and others added 2 commits February 24, 2025 09:27
Co-authored-by: Stanislas <skita@teclib.com>
Co-authored-by: Stanislas <skita@teclib.com>
@RomainLvr RomainLvr requested a review from stonebuzz February 24, 2025 08:28
@stonebuzz stonebuzz merged commit 1ed8bcb into pluginsGLPI:main Feb 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants