Skip to content

formatNumber Cast currency value to float#35

Merged
Rom1-B merged 2 commits intopluginsGLPI:mainfrom
MrYoloPotato:main
Aug 20, 2025
Merged

formatNumber Cast currency value to float#35
Rom1-B merged 2 commits intopluginsGLPI:mainfrom
MrYoloPotato:main

Conversation

@MrYoloPotato
Copy link

@MrYoloPotato MrYoloPotato commented Jul 28, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes the issue of "Argument 2 ($amount) must be of type float, string given" when printing to PDF with the "Management" option checked
  • It just casts the $value to float

@MrYoloPotato MrYoloPotato changed the title Cast value to float, fixes "must be of type float, string given" when… Cast currency value to float Jul 28, 2025
@MrYoloPotato MrYoloPotato changed the title Cast currency value to float formatNumber Cast currency value to float Jul 28, 2025
@Rom1-B Rom1-B self-requested a review July 29, 2025 08:38
@Rom1-B Rom1-B requested a review from stonebuzz August 20, 2025 06:40
@Rom1-B Rom1-B merged commit 9680643 into pluginsGLPI:main Aug 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants