Skip to content

fix(pdf) Prevent nl2br from interfering with HTML table structure#41

Merged
Rom1-B merged 5 commits intopluginsGLPI:10.0/bugfixesfrom
MyvTsv:ticket39537
Oct 6, 2025
Merged

fix(pdf) Prevent nl2br from interfering with HTML table structure#41
Rom1-B merged 5 commits intopluginsGLPI:10.0/bugfixesfrom
MyvTsv:ticket39537

Conversation

@MyvTsv
Copy link

@MyvTsv MyvTsv commented Oct 2, 2025 •
edited
Loading

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !39537
  • If a follow-up consists solely of a table, it is incorrectly formatted. Furthermore, when no border size is specified (as is the case when copying and pasting from Excel), the borders are not retained in the PDF.

Screenshots (if appropriate):

Ticket:
image

Before:
image

image

After:
image

@MyvTsv MyvTsv self-assigned this Oct 2, 2025
@MyvTsv MyvTsv marked this pull request as ready for review October 2, 2025 13:38
@MyvTsv MyvTsv requested review from Rom1-B and stonebuzz October 2, 2025 13:39
stonebuzz
stonebuzz approved these changes Oct 2, 2025
View reviewed changes
Copy link

@stonebuzz stonebuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

Rom1-B
Rom1-B requested changes Oct 2, 2025
View reviewed changes
MyvTsv and others added 3 commits October 3, 2025 09:56
@MyvTsv @Rom1-B
Update inc/simplepdf.class.php
79ef5b0 
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@MyvTsv @Rom1-B
Update inc/simplepdf.class.php
995f445 
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@MyvTsv @Rom1-B
Update inc/simplepdf.class.php
fcb9fb7 
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@MyvTsv MyvTsv requested review from Rom1-B and stonebuzz October 6, 2025 12:41
@Rom1-B Rom1-B merged commit 7418585 into pluginsGLPI:10.0/bugfixes Oct 6, 2025
3 checks passed
@MyvTsv MyvTsv mentioned this pull request Nov 12, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stonebuzz stonebuzz stonebuzz approved these changes

@Rom1-B Rom1-B Rom1-B approved these changes

Assignees

@MyvTsv MyvTsv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MyvTsv @stonebuzz @Rom1-B