-
Notifications
You must be signed in to change notification settings - Fork 8
Refine Dutch translations in nl.json #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MathijsG
wants to merge
2
commits into
plugwise:main
Choose a base branch
from
MathijsG:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−44
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review the hyphen prefix in error message.
The construction "of -foutmelding" on line 328 is grammatically unusual in Dutch. The hyphen prefix before "foutmelding" doesn't follow standard Dutch conventions.
This message appears in two places:
"of foutmelding ontvangen""of -foutmelding ontvangen"Consider one of these alternatives for consistency and clarity:
"of foutmelding ontvangen"(matches line 45)"of een XML-foutmelding ontvangen""of XML-foutmelding ontvangen"🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderabbitai would the use of the hyphen prefix be correct when the comma is removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
💡 Result:
Do you mean the suspended‑hyphen construction where two or more words share a common part (e.g. vis- en vleesproducten) or something else? If you can give one or two example phrases you have in mind (like "soja- of maïszetmeel" or "tweede- of derdeklasser"), I’ll explain the correct hyphenation rule and show the right forms with sources.
🌐 Web query:
💡 Result:
"Opschortend koppelteken" (ook: weglatingsstreepje of samentrekking) gebruik je wanneer je een gedeeld deel van twee of meer samenstellingen weglaat en dat vervangt door een koppelteken. Regels en korte voorbeelden:
Bronnen: Taalwinkel (UvA/HvA) [1], Vlaanderen.team‑taaladvies (spellingregels samentrekking) [2], NLS Online (uitleg samentrekking/koppelteken) [3].
@bouwew No, the hyphen prefix would still not be correct without the comma.
The Dutch "opschortend koppelteken" (suspended hyphen) construction you might be thinking of—like "voor- en nadelen" (pros and cons)—only works when the shared element comes at the end of the compound words. In that example, both words share "-delen": voordelen and nadelen → voor- en nadelen.
In "XML-data of -foutmelding", you would be trying to share "XML-" at the beginning, which doesn't follow this grammatical pattern. The suspended hyphen doesn't work for shared prefixes in this way.
For the error message, these options would be grammatically correct:
I'd recommend the first option for consistency with the existing
config.error.response_errormessage.🧠 Learnings used