-
Notifications
You must be signed in to change notification settings - Fork 2
Update code for production-power levels #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## async #209 +/- ##
==========================================
+ Coverage 81.16% 81.21% +0.04%
==========================================
Files 36 36
Lines 7364 7367 +3
==========================================
+ Hits 5977 5983 +6
+ Misses 1387 1384 -3 ☔ View full report in Codecov by Sentry. |
|
|
Confirmed working by @digisaster: |
brefra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the ability to test this and curious if the energy production counters are working too.
I agree with the change, despite the fact that this makes the power measurement a bit unexpected (sometimes a small negative value) if no load is connected to a circle
|
Good point I'll ask @digisaster for info on the cumulative production sensors. This "small negative value" that @dirixmjm reports, seems to be limited to single Circles. I don't see this issue in the results of any of my Circles or of my Stealth M+. To be investigated further... |




No description provided.