Skip to content

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Mar 23, 2025

All changes:

  • Add support for devices with production enabled (setting Deliver energy / Levert energie in Source required).
  • Fix rollover behaviour (cumulative sensor-rollover is based on the device-rollover).
    • Hourly rollover is based on device pulse counter reset
    • Daily rollover synced with device hourly-rollover
  • Add/improve logger messages.
  • Fix missing await-message in HA (a24cb79, e43e97e).
  • Small improvements, add a missing line, add guarding.
  • Adapt/improve testing

@coderabbitai
Copy link

coderabbitai bot commented Mar 23, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

Attention: Patch coverage is 78.89908% with 23 lines in your changes missing coverage. Please review.

Project coverage is 81.45%. Comparing base (077a435) to head (7836e01).
Report is 158 commits behind head on async.

Files with missing lines Patch % Lines
plugwise_usb/nodes/helpers/pulses.py 84.84% 10 Missing ⚠️
plugwise_usb/nodes/helpers/counter.py 63.63% 8 Missing ⚠️
plugwise_usb/nodes/circle.py 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            async     #218      +/-   ##
==========================================
+ Coverage   81.21%   81.45%   +0.24%     
==========================================
  Files          36       36              
  Lines        7367     7378      +11     
==========================================
+ Hits         5983     6010      +27     
+ Misses       1384     1368      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bouwew bouwew marked this pull request as ready for review April 12, 2025 05:16
@sonarqubecloud
Copy link

@bouwew
Copy link
Contributor Author

bouwew commented Apr 12, 2025

The delaying of the daily reset is finally working :)

Now it's time for reviewing :)

@bouwew bouwew requested a review from ArnoutD April 12, 2025 05:29
@bouwew
Copy link
Contributor Author

bouwew commented Apr 12, 2025

@brefra @ArnoutD @dirixmjm Please review this backend library PR in combination with this PR: plugwise/plugwise_usb-beta#220

I would like to merge both these PR's so I can work on other improvements/updates.

@bouwew bouwew merged commit 932ae6b into async Apr 16, 2025
31 of 32 checks passed
@bouwew bouwew deleted the neg-energy-4 branch April 16, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants