Refactor population factory to remove plotting logic and make it a p…#23
Merged
Refactor population factory to remove plotting logic and make it a p…#23
Conversation
…re population-construction module. Update tests to use real HISCALE example data and add an example notebook demonstrating the BEASD + AIMMS + miniSPLAT + AMS workflow.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
===========================================
+ Coverage 80.64% 92.53% +11.89%
===========================================
Files 65 74 +9
Lines 4299 4476 +177
===========================================
+ Hits 3467 4142 +675
+ Misses 832 334 -498
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the HISCALE population builder to separate population construction from analysis/visualization workflows.
hiscale_observations.py is now a pure builder that ingests observational datasets and constructs a ParticlePopulation. Plotting and validation workflows have been moved to a dedicated example notebook.