Skip to content

Refactor population factory to remove plotting logic and make it a p…#23

Merged
lfierce2 merged 1 commit intomainfrom
features/hiscale-example
Mar 16, 2026
Merged

Refactor population factory to remove plotting logic and make it a p…#23
lfierce2 merged 1 commit intomainfrom
features/hiscale-example

Conversation

@lfierce2
Copy link
Collaborator

This PR refactors the HISCALE population builder to separate population construction from analysis/visualization workflows.

hiscale_observations.py is now a pure builder that ingests observational datasets and constructs a ParticlePopulation. Plotting and validation workflows have been moved to a dedicated example notebook.

…re population-construction module. Update tests to use real HISCALE example data and add an example notebook demonstrating the BEASD + AIMMS + miniSPLAT + AMS workflow.
@lfierce2 lfierce2 requested a review from lfierce3 as a code owner March 16, 2026 22:18
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 96.72131% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.53%. Comparing base (43046ee) to head (8f7d4a4).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/part2pop/analysis/particle/factory/mass_dry.py 82.35% 3 Missing ⚠️
src/part2pop/analysis/particle/factory/mass_tot.py 82.35% 3 Missing ⚠️
...part2pop/analysis/particle/factory/abs_crossect.py 94.11% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #23       +/-   ##
===========================================
+ Coverage   80.64%   92.53%   +11.89%     
===========================================
  Files          65       74        +9     
  Lines        4299     4476      +177     
===========================================
+ Hits         3467     4142      +675     
+ Misses        832      334      -498     
Flag Coverage Δ
unittests 92.53% <96.72%> (+11.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lfierce2 lfierce2 merged commit f3c3180 into main Mar 16, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants