feat: Colorize json if detected #485
Conversation
adameska
force-pushed
the
JsonColorize
branch
from
e64f8c0 to
fe5667c
Compare
Signed-off-by: Hettinger, David <DHETTINGER@quad.com>
Signed-off-by: Hettinger, David <DHETTINGER@quad.com>
Signed-off-by: Hettinger, David <DHETTINGER@quad.com>
adameska
force-pushed
the
JsonColorize
branch
from
fe5667c to
92a2f4c
Compare
Signed-off-by: Adameska <hettinger14@outlook.com>
gastoner
left a comment
gastoner
left a comment
There was a problem hiding this comment.
Otherwise it seems like I get some highlighted words on Linux 👍
| expect(result2).toContain('\u001b[36m'); | ||
| }); | ||
|
|
||
| test('should handle abbreviated log levels', () => { |
There was a problem hiding this comment.
Can you please use test.each? Here is an example https://github.com/podman-desktop/podman-desktop/blob/main/extensions/podman/packages/extension/src/extension.spec.ts#L399
| }); | ||
|
|
||
| test('should handle full word log levels', () => { | ||
| const testCases = [ |
| * @param lines - Array of log lines to analyze | ||
| * @returns true if logs should be treated as JSON format | ||
| */ | ||
| export function detectJsonLogs(lines: string[]): boolean { |
There was a problem hiding this comment.
Would be possible to do this for every line of logs? WDYT @feloy
There was a problem hiding this comment.
Logs may have thousands of lines. And generally, all lines are in Json format, or none of them are, so this test seems legit to me
There was a problem hiding this comment.
I prefer this route, the less i have to know/do the better... and colorizing lots of lines of json was plenty fast for me on my machine but the concern is valid. We could also add a menu option here if/when this PR gets completed to drive this behavior too... #417
Signed-off-by: Adameska <hettinger14@outlook.com>
3 participants
Logs before:
Logs after:
