Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds a pyinstaller for piranha. The exectutable built with the installer will be bundled with the piranhaNET Electron app.
For ease of debugging the installer is currently building to a folder, but we'll change that to a single executable later.
This branch also adds a copy of the piranha test data, hence the eye-watering line change count.
To test, follow the instructions in
piranha-installer/README.mdto activate a micromamba environment, build the installer and runtest-run-exeto run the bundled piranha executable against the test data.We will also include github workflow to build the installer for Ubuntu, Windows, and Mac, and run it on a fresh machine.
TODO: Build and test installer in separate jobs via artifact