Added support for language selector #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed link to the config file in the readme
When using a radio with a collection of e.g. [1, 0, -1], the ids of the generated input tags are the same for 1 and -1. By not stripping '-', we get unique ids in this case.
…eing displayed without this patch
* Rails 3.1 nested inputs won't work unless the nested attributes collection returns a non-empty collection * stub Author#persisted? to get another test passing * stub controller, default_url_options, _routes, _routes.url_helpers, _routes.url_helpers.has_for_..._path, etc * f.fields_for(:some_association) in Rails 3.1 checks for the some_association= method on the parent model, so we need to stub it Disabled some failing i18n specs for now.
…and 3.0.7. * Model_name in Rails 3 can be `author` or `post[author]`. In Rails 3.1 always `author`. Rails 3.1 introduces `builder.parent_builder`, so we use `builder.parent_builder.object` name for the parent (`post`) bit if available, and `f.semantic_fields_for` will pass `:parent_builder` to `f.form_for` as an option to provide similar functionality in Rails 3.0. * The nested translation tests in for the above code really didn't cover the common use cases, so I re-wrote a lot of them, added extras, etc. * Rails 3.1 also doesn't seem to instantiate the nested builder as a Formtastic::FormBuilder if the parent form is using `:post` instead of `@post`, so converted the specs to work with real objects. * The tests for falling back to Rails-style translations didn't make sense to me so I re-wrote them and adding coverage for nesting. Fixes formtastic#564
Don't strip '-' in choice_html_safe_value
fix for broken semantic_fields_for - Issue formtastic#574
Allow has_many and has_many_through relationships to be validated if included in a form
Fix syntax error in Ruby 1.9.2
Boolean fields should not use global requied default. Fixes formtastic#580
* removed formtastic_changes.css * moved formtastic.css into app/assets/stylesheets/formtastic.css * changed install generator to only copy formtastic.css in Rails < 3.1 * changed install generator to source the stylesheet template from new location * added formtastic/engine.rb, which seems to be needed to trigger asset pipeline * updated documentation Also modified install instructions in README to include bundling from master. For Rails 3.1, instead of copying the styles across with a generator, simply add them to your application.css with sprockets: `*= require formtastic`
…d, avoids duplicates (fixes formtastic#576)
…nfig template (ref formtastic#581)
Fixes formtastic#584 . Retry if value received from i18n is not a string
…formtastic#547). Just over a third of the time it used to take. # before Finished in 178.55 seconds 1148 examples, 0 failures #after Finished in 66.23 seconds 1148 examples, 0 failures
README: Fix examples in Modified & Custom Inputs
Switch to gemspec generated by bundler.
…rator to override scaffold generator (closes formtastic#461)
Update commit_button documentation
… and [id] attributes, ref formtastic#711
The syntax introduced in 253dc6d, eg. concat(builder.fields_for :author, :index => 3 do |author| was producing these errors: syntax error, unexpected keyword_do_block, expecting ')' (SyntaxError)
Address syntax errors when running specs under 1.9.2-p290
Before this change, it wasn't possible to create an input of type 'time' that didn't default to the current date. This made it impossible to differentiate between a form submission wherein the user hadn't picked a date, and one in which they'd picked midnight UTC.
Signed-off-by: Joel Nimety <jnimety@continuity.net>
…er-maxlength-as-bytes calculate length of integer columns as bytes
…of :input_html option in order to take effect while using f.input :as => :select.
Documentation update: :include_blank option should be passed outside of :
Fixed up the documentation for text_input
A failing test.
A passing test.
…or and always returns empty results
Fix for formtastic#740 (Mongoid belongs_to select raises NoMethodError and always returns empty results)
Fix for `builder.with_options`
Bring time input behavior in line with time_select when inputs are empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also the railtie now handles and set up for either normal or localized country/language plugins.
The README was also updated to reflect this and include instructions for how to set the 'prioritized' list in each selector (was missing before - had to look into the code to figure this out!).
Cheers!