Add optional password secret#72
Open
derfabianpeter wants to merge 2 commits intoportainer:add-optional-password-secretfrom
Open
Add optional password secret#72derfabianpeter wants to merge 2 commits intoportainer:add-optional-password-secretfrom
derfabianpeter wants to merge 2 commits intoportainer:add-optional-password-secretfrom
Conversation
Contributor
|
I got auto-tagged as a codeowner reviewer, but the latest comment says this is still a WIP. Let me know if / when you'd like me to review ;) |
Author
|
Hi,
I’ve added a bit of context to the PR in the p3r Slack as there’s room for discussion
… Am 17.08.2021 um 07:13 schrieb David Young ***@***.***>:
I got auto-tagged as a codeowner reviewer, but the latest comment says this is still a WIP. Let me know if / when you'd like me to review ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#72 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVPBPNYFVDWHBMM4TT5M5TT5HVV7ANCNFSM5CH3563A>.
|
|
Sorry to dig back this PR, but I also tried to configure default password with Helm / Ansible. I went with something like this right after invoking the helm initial installation in my Ansible playbook: Right before, creating my own secret using Then, in my playbook I think that we should not create the secret manifest automatically w/ Helm. Rather, document that the user has to do it with the tools at his disposal, and just add to helm definition something like: |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked the solution as suggested in PR71.
Still WIP. With the current implementation (using HELM's built-in
htpasswdfunction), login with configured credentials is not possible. I suspend this to be a result of HELM's htpasswd not using bycrypt.