Add https for getting the URL in NOTES.txt.#95
Open
d1mnewz wants to merge 2 commits intoportainer:masterfrom
Open
Add https for getting the URL in NOTES.txt.#95d1mnewz wants to merge 2 commits intoportainer:masterfrom
d1mnewz wants to merge 2 commits intoportainer:masterfrom
Conversation
d1mnewz
commented
Feb 7, 2022
| {{- else if contains "ClusterIP" .Values.service.type }} | ||
| Get the application URL by running these commands: | ||
| export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app.kubernetes.io/name={{ include "portainer.name" . }},app.kubernetes.io/instance={{ .Release.Name }}" -o jsonpath="{.items[0].me$ echo "Visit http://127.0.0.1:9443 to use your application" | ||
| export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app.kubernetes.io/name={{ include "portainer.name" . }},app.kubernetes.io/instance={{ .Release.Name }}" -o jsonpath="{.items[0].me$ echo "Visit https://127.0.0.1:9443 to use your application" |
Author
There was a problem hiding this comment.
curios whether makes sense if you are doing port forwarding.
There was a problem hiding this comment.
I think it makes sense. You've tested this?
Author
There was a problem hiding this comment.
Nope, not really. But the internet says it should work.
hookenz
approved these changes
Feb 7, 2022
hookenz
left a comment
hookenz
left a comment
There was a problem hiding this comment.
LGTM
It makes no sense to connect to the secure port with http.
deviantony
reviewed
Feb 8, 2022
Member
deviantony
left a comment
deviantony
left a comment
There was a problem hiding this comment.
LGTM but should probably be tested first
Author
|
I'll test and give you an update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.