Fix: Runtime session not shutting down when notebook is closed #10636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
dhruvisompura
approved these changes
Nov 18, 2025
Contributor
dhruvisompura
left a comment
dhruvisompura
left a comment
There was a problem hiding this comment.
🚀 This is working well for me!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dispose cells when a notebook is disposed, so that text model references aren't leaked, the notebook document is closed, and the runtime session is shutdown. Addresses #10215.
Screen.Recording.2025-11-18.at.18.54.23.mov
Release Notes
New Features
Bug Fixes
QA Notes
Repro steps:
x = 1xdoesn't exist - FAILYou can also check in the Runtimes dev pane.