Skip to content

Add ability to select system mods in simulate#290

Merged
stanriders merged 4 commits intoppy:masterfrom
Givikap120:add-system-mods
Jan 24, 2026
Merged

Add ability to select system mods in simulate#290
stanriders merged 4 commits intoppy:masterfrom
Givikap120:add-system-mods

Conversation

@Givikap120
Copy link
Contributor

This is essential if you want to test specific ScoreV2 or Touchscreen scores

@stanriders
Copy link
Member

I've tried to avoid using reflection in tools since it's always a mess in terms of maintainence, but having system mods would be really useful. Do you think there's no other way of implementing this? Maybe somehow adding a non-system version of those mods locally or something?..

@Givikap120
Copy link
Contributor Author

Givikap120 commented Dec 10, 2025

I've tried to avoid using reflection in tools since it's always a mess in terms of maintainence, but having system mods would be really useful. Do you think there's no other way of implementing this? Maybe somehow adding a non-system version of those mods locally or something?..

The only way to avoid reflection I see is making osu-lazer PR that will change accessibility to protected.
Because the problem is that there's just nothing you could do with the Mod Select (everything is private), unless you want to create entirely new Mod Select, copying all the code.

@stanriders stanriders added the perfcalc-gui PerformanceCalculatorGUI label Jan 24, 2026
Copy link
Member

@stanriders stanriders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I hate adding reflection to this project, there is absolutely no other way around it here - everything is completely walled off

@stanriders stanriders merged commit e4c8e9a into ppy:master Jan 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perfcalc-gui PerformanceCalculatorGUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants