Add support for calculating scores from client.realm#300
Open
TextAdventurer12 wants to merge 4 commits intoppy:masterfrom
Open
Add support for calculating scores from client.realm#300TextAdventurer12 wants to merge 4 commits intoppy:masterfrom
TextAdventurer12 wants to merge 4 commits intoppy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #299
Supercedes #213
#299 is needed since realm returns
ScoreInfo, and notSoloScoreInfo. That, as well as some other extra things added to tools since #213 went inactive (such as the toggles) mean this is a lot simpler than #213 .Everything is implemented into the
RealmScreen, which is basically just a copy ofProfileScreen.client.realmshould be inside the folder thatRealmPathis set to (using lazer path should let live tracking work, but it's safer to manually copy overclient.realmto therealmfolder in tools (I put a dummy file in there so git would let me commit the folder - did not dox my install lol).Only supports one user being calculated, since I wouldn't expect anyone to have a significant enough number of local scores from other users for it to ever be useful to calculate more than one profile.
Runs pretty quickly on my machine, <1 minute for ~1k local scores. Not sure if there's much reason to optimise further, although it might be an issue for users with a lot of maps and local scores, so probably best to see how slowly it runs for other people.