tests: Run check-namespace script also for tests all #1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the check-namespacing script is only run when tests func --check-namespace is called For tests all, the --check-namespace has no effect. This commit fixes that by adding the namespace check to the all test as well. This is important as we only run the all target in CI. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
hanno-becker
force-pushed
the
namespace-test-all
branch
from
ec10bd7 to
5ce71b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the check-namespacing script is only run when tests func --check-namespace
is called
For
tests all, the --check-namespace has no effect.
This commit fixes that by adding the namespace check to the all test as well.
This is important as we only run the all target in CI.